Fix URL routing and mitigate XSS in template rendering#35
Conversation
- Updated Regex to `(.+)` in `worker.js` to correctly capture URIs containing slashes (e.g. from base64 encoding) on `/c/` and `/w/` routes. - Added `escapeForScript` helper to sanitize parameters before injecting them into HTML/JS templates, protecting against XSS. - Changed `.replace()` string replacements to use the callback form, avoiding errors caused by special characters like `$&` in payload data. Co-authored-by: jbalagiya <143921503+jbalagiya@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fix URL routing and mitigate XSS in template rendering
(.+)inworker.jsto correctly capture URIs containing slashes (e.g. from base64 encoding) on/c/and/w/routes.escapeForScripthelper to sanitize parameters before injecting them into HTML/JS templates, protecting against XSS..replace()string replacements to use the callback form, avoiding errors caused by special characters like$&in payload data.PR created automatically by Jules for task 8686707472271991792 started by @jbalagiya