Fix URL routing and template injection vulnerabilities#32
Conversation
- Added `escapeForScript` helper to sanitize string injections in templates and prevent XSS. - Changed `renderTemplate` logic to use a callback function in `.replace` calls to avoid issues with special replace patterns like `$&`. - Fixed regex matching for `/c/` and `/w/` paths. The second parameter can contain forward slashes (since it is a base64 string, or due to decoded URLs), so using `([^/]+)` breaks the worker route logic; it now uses `(.+)`. Co-authored-by: jbalagiya <143921503+jbalagiya@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR resolves several key issues with routing and templating in the Worker:
/c/and/w/endpoints).$&would be incorrectly processed byString.prototype.replace().PR created automatically by Jules for task 6161346864677551753 started by @jbalagiya