Fix regex routing and template XSS vulnerabilities#31
Conversation
- Updated regex matchers for `/c/` and `/w/` routes to use `(.+)` to properly capture base64 URIs that contain slashes. - Introduced `escapeForScript` helper to sanitize dynamic variables before inserting them into HTML/JS templates. - Updated `renderTemplate` to use the callback form of `.replace()` to prevent `$&` special string replacement bugs. Co-authored-by: jbalagiya <143921503+jbalagiya@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR addresses bugs and security vulnerabilities in
worker.js:/c/uid/base64uriused([^/]+)for the final segment. If a base64 encoded string or raw URL contained a slash, it would fail to capture the full URI. This was changed to(.+).renderTemplate(), usingString.prototype.replace()without a replacement callback is vulnerable to string corruption if the dynamic data contains$&,$', etc. We implemented a replacement callback.escapeForScript()sanitization function to properly escape quotes and control characters, preventing Cross-Site Scripting (XSS) and syntax errors when rendering dynamic data into the HTML template scripts.PR created automatically by Jules for task 10047467946195169608 started by @jbalagiya