Fix routing regex and prevent XSS in templates#24
Conversation
- Updated routing regex for `/c/` and `/w/` to correctly match base64 encoded URIs containing forward slashes. - Introduced `escapeForScript` helper to escape JavaScript strings, preventing syntax breakage and XSS. - Modified `renderTemplate` to use the helper and pass a callback to `replace()` to prevent `$1`/`$&` bugs. Co-authored-by: jbalagiya <143921503+jbalagiya@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fix routing regex and prevent XSS in templates
/c/and/w/to correctly match base64 encoded URIs containing forward slashes.escapeForScripthelper to escape JavaScript strings, preventing syntax breakage and XSS.renderTemplateto use the helper and pass a callback toreplace()to prevent$1/$&bugs.PR created automatically by Jules for task 15718689413240603139 started by @jbalagiya