Fix routing regex and add template escaping in worker.js#22
Conversation
- Updated routing regex for `/c/` and `/w/` endpoints to properly handle slashes in base64 strings by using `(.+)` instead of `([^/]+)`. - Introduced `escapeForScript` helper to sanitize dynamic data injected into JS templates. - Modified `renderTemplate` to use the callback form of `.replace()` to prevent `$&` special string replacement bugs. Co-authored-by: jbalagiya <143921503+jbalagiya@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes two bugs in
worker.js:/c/and/w/would break when decoding base64 payload URIs that contained slashes. They now correctly capture the full URI by using(.+).renderTemplatecould cause XSS or string replacement issues (like$&backreferences). Added anescapeForScripthelper and updated the replacements to use a callback, safely rendering the dynamic strings.PR created automatically by Jules for task 10081598511616376399 started by @jbalagiya