Fix routing and XSS vulnerabilities in template rendering#20
Conversation
…e rendering - Updated path regex matching in `/c/` and `/w/` routes to use `(.+)` instead of `([^/]+)` to support Base64-encoded paths that may contain slashes. - Created `escapeForScript` utility function to properly escape strings meant for JS injection. - Refactored `renderTemplate` to use the new escape function and switch to a callback approach for `String.prototype.replace()` to prevent string interpolation bugs involving `$&`. Co-authored-by: jbalagiya <143921503+jbalagiya@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fix URL routing regex to support slashes and mitigate XSS risks by safely escaping template variables and using callback functions in replace methods.
PR created automatically by Jules for task 9618320728351392935 started by @jbalagiya