Skip to content

Fix WordCounterSpliterator.tryAdvance #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix WordCounterSpliterator.tryAdvance #10

wants to merge 1 commit into from

Conversation

uprem
Copy link

@uprem uprem commented Sep 10, 2016

fixes:

  1. when initial string is empty, prevents throwing StringIndexOutOfBoundsException
  2. the last valid iteration return true. old code returns false for the last character which breaks tryAdvance() specs

@uprem
Fix WordCounterSpliterator.tryAdvance
931f17e 
fixes:
1. when initial string is empty, prevents throwing StringIndexOutOfBoundsException
2. the last valid iteration return true. old code returns false for the last character which breaks tryAdvance() specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@uprem