Fix leak in runServerWithOptions
#259
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The structure of `mainThread` in `runServerWithOptions` was
```hs
mainThread = do
...
Async.withAsyncWithUnmask ... $ \theNewAsync ->
mainThread
```
This means that every async created (to deal with incoming requests) are
retained for the lifetime of the server: this in turn holds on the
corresponding `ThreadId`s, and therefore the corresponding TSOs, resulting in a
memory leak.
In this commit we instead maintain an `IORef` of all app threads, so that we
can kill them if need be; every thread unregisters itself when it completes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structure of
mainThreadinrunServerWithOptionswasThis means that every async created (to deal with incoming requests) are retained for the lifetime of the server: this in turn holds on the corresponding
ThreadIds, and therefore the corresponding TSOs, resulting in a memory leak.In this commit we instead maintain an
IORefof all app threads, so that we can kill them if need be; every thread unregisters itself when it completes.