Skip to content

Distribution comparison#226

Open
Kucharssim wants to merge 16 commits intojasp-stats:masterfrom
Kucharssim:distribution-comparison
Open

Distribution comparison#226
Kucharssim wants to merge 16 commits intojasp-stats:masterfrom
Kucharssim:distribution-comparison

Conversation

@Kucharssim
Copy link
Member

This adds a tool for comparing various distributions and assessing their fit to data.

@Kucharssim Kucharssim requested a review from JTPetter February 13, 2026 16:22
@JTPetter
Copy link

@Kucharssim I’ve tested it, and everything works very well. I also don’t have any comments on the code itself.

My only suggestion concerns the GUI. It might be more intuitive to allow users to add distributions through a dropdown menu, checkboxes, or a similar selection mechanism rather than via “code.”

At the moment, I find it somewhat confusing that I have to enter parameter values even when they are estimated freely. For some distributions, I’m not even sure how they are parameterized, so I would essentially be entering arbitrary numbers. Being able to simply select distributions from a list would make the process clearer and avoid that.

@tomtomme tomtomme added the enhancement New feature or request label Feb 17, 2026
@Kucharssim
Copy link
Member Author

Kucharssim commented Feb 17, 2026

Thanks for the review!

Yes, I initially intended to implement the distribution specification using something like TabView with DropDown etc, but this made the GUI (and the QML code behind it) really bloated. I hoped that adding the "preset" buttons and the additional helpfile for the syntax would make this approach more user friendly, but I do agree that it's not ergonomic to be looking at the help file all the time.

I will look into it again if I can find some alternative/compromise solution (or just implement the TabView and will have to live with it :D).

@juliuspfadt
Copy link

is this ready @Kucharssim?

@Kucharssim
Copy link
Member Author

Kucharssim commented Feb 26, 2026

Not yet ready, I still need to update the PR (will be done this week)

@Kucharssim Kucharssim force-pushed the distribution-comparison branch from eb3e43b to fa8f1ee Compare February 28, 2026 09:36
@Kucharssim
Copy link
Member Author

I still need to update tests and handle some edge cases, but if you want you can have a look at the new interface, @JTPetter. Thanks!

@Kucharssim Kucharssim requested a review from JTPetter March 1, 2026 11:00
@juliuspfadt
Copy link

@JTPetter, @ejw is keen on having this PR in the release. To be fair, I dont know how imminent that is, maybe @boutinb can say more about it? Let me know if you need any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants