Manipulating value of labels may cause a crash in debug mode.#6258
Merged
Conversation
shun2wang
reviewed
Jun 10, 2026
Lets try it, because I also still get the crash Co-authored-by: Shun Wang <shuonwang@gmail.com>
Contributor
|
Looks like this at least fixes the original crash. Im looking into this a bit more to see if I can add some more tests for this |
JorisGoosen
reviewed
Jun 11, 2026
Contributor
|
I need to test these changes but my worksystem is now in a state of limbo because im recom-piling webengine a bunch, but its crashing now. The dialog really neeeds to be tested and checked still so dont merge |
9686af3 to
5cced61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/3236
A unit test is added in testdebugdata.
First fix was to add rememberCurrentOrigValDisplay when _labelMapUpdates is called.
But a second fix is necessary: