Skip to content

Fix infinite loop in triangulator #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sk-zk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix infinite loop in triangulator #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions LilyPath/Triangulator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ public void Triangulate (IList<Vector2> points, int offset, int count)

int index = 0;
int computeIndex = 0;

int unsuccesfulLoops = 0;
while (count >= 3) {
bool isEar = true;

Expand Down Expand Up @@ -75,9 +77,17 @@ public void Triangulate (IList<Vector2> points, int offset, int count)
_triPrev[_triNext[index]] = _triPrev[index];
count--;
index = _triPrev[index];
unsuccesfulLoops = 0;
}
else {
index = _triNext[index];
unsuccesfulLoops++;
}

// give up if no ears have been found two times in a row.
// prevents an infinite loop.
if (unsuccesfulLoops > 1) {
break;
}
}

Expand Down