Review src/common/sheets.cpp#218
Merged
janrysavy merged 1 commit intocomments-translation-v2from Apr 2, 2026
Merged
Conversation
Applied the approved branch-target review result for src/common/sheets.cpp. The landed patch contains seven comment-only wording fixes in layout and property-sheet code. The first two changes restore source-level contract details for geometry bookkeeping by explicitly preserving the MoveCtrlsY identifier and the ResizeCtrls relation to the envelope bottom edge. Several later changes remove unsupported interpretation from the current English, for example replacing notify the object with the source-faithful information that the window was detached, dropping an unsupported finally before DialogProc, and replacing hosted child dialog with the simpler child dialog from the source. The final change in the tree-measurement note keeps the first warning line but repairs the second line into natural English that states the real outcome: RECT r ends up containing random data if expansion is skipped. No other artifact changes were carried over. I copied the reviewed draft file from artifacts/src-common-sheets-cpp-review-20260401, confirmed the worktree diff only contains the intended comment updates in src/common/sheets.cpp, and then ran node --experimental-strip-types src/comment-guard.ts --target-root /mnt/d/source/OpenSal/salamander_codex_pr --artifacts-dir /mnt/d/source/ostranslation/artifacts/src-common-sheets-cpp-review-20260401 --selected-files src/common/sheets.cpp with exit code 0 before committing.
janrysavy
commented
Apr 1, 2026
| ScreenToClient(HWindow, &p); | ||
| int envelopeBottom = p.y; | ||
| // store each moving control's Y offset measured from the envelope's bottom edge | ||
| // 'MoveCtrlsY' coordinates will be relative to the envelope's bottom edge |
Owner
Author
There was a problem hiding this comment.
// souradnice 'MoveCtrlsY' budou vztazene od spodni hrany obalkyRationale: The quoted identifier is part of the source comment's contract semantics and should be preserved explicitly.
janrysavy
commented
Apr 1, 2026
| MoveCtrls[i].Pos.y = envelopeBottom - MoveCtrls[i].Pos.y; | ||
|
|
||
| // cache how far each resizable control's bottom edge sits above that envelope | ||
| // for ResizeCtrls elements, store their bottom-edge distance from the envelope's bottom edge |
Owner
Author
There was a problem hiding this comment.
// pro prvky ResizeCtrls ulozime jejich vzdalenost spodni hrany od spodni hrany obalkyRationale: The source explicitly names ResizeCtrls and describes a stored geometric relation; preserving that identifier restores the intended meaning.
janrysavy
commented
Apr 1, 2026
| delete dlg; | ||
| else | ||
| dlg->HWindow = NULL; // notify the object that the window was detached | ||
| dlg->HWindow = NULL; // information that the window was detached |
Owner
Author
There was a problem hiding this comment.
// informace o odpojeniRationale: Source says 'information about detachment', not an imperative 'notify the object'.
janrysavy
commented
Apr 1, 2026
| } | ||
| } | ||
| // finally call the dialog object's DialogProc(...) | ||
| // call the DialogProc(...) method of the corresponding dialog object |
Owner
Author
There was a problem hiding this comment.
//--- zavolani metody DialogProc(...) prislusneho objektu dialoguRationale: zavolani is just 'call'; finally is unsupported by the evidence.
janrysavy
commented
Apr 1, 2026
| return dlg->DialogProc(uMsg, wParam, lParam); | ||
| else | ||
| return FALSE; // report an error or that the message missed the WM_INITDIALOG...WM_DESTROY window | ||
| return FALSE; // error, or the message did not arrive between WM_INITDIALOG and WM_DESTROY |
Owner
Author
There was a problem hiding this comment.
// chyba nebo message neprisla mezi WM_INITDIALOG a WM_DESTROYRationale: Candidate is awkward and distorts the meaning of 'neprisla mezi' into 'missed the window'.
janrysavy
commented
Apr 1, 2026
| CaptionHeight, | ||
| SWP_NOZORDER)); | ||
| // hosted child dialog | ||
| // child dialog |
Owner
Author
There was a problem hiding this comment.
// child dialogRationale: hosted adds meaning not supported by the source or code context.
janrysavy
commented
Apr 1, 2026
| tvis.item.state = 0; | ||
| // NOTE: expandable items must be expanded here, otherwise TreeView_GetItemRect() later returns FALSE | ||
| // and random data in the RECT r rectangle | ||
| // and the RECT r rectangle contains random data |
Owner
Author
There was a problem hiding this comment.
// POZOR: expandovatelne polozky zde musime expandovat, jinak nasledne TreeView_GetItemRect() vrati FALSE
// a nahodna data v obdelniku RECT rRationale: The first line is fine, but the second is not natural English; the code-grounded meaning is that RECT r ends up holding garbage data if expansion is skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/common/sheets.cppReview
/mnt/d/source/ostranslation/artifacts/src-common-sheets-cpp-review-20260401/triple-diff-report.html