Review src/common/regexp.h#217
Merged
janrysavy merged 1 commit intocomments-translation-v2from Apr 2, 2026
Merged
Conversation
Applied the approved branch-target review result for src/common/regexp.h. The landed change rewrites the ExpandVariables API comment block into clearer technical English without changing the documented contract. The old wording used awkward and slightly imprecise terms such as template for the replacement text and expression for the final expanded output. The new version consistently describes a replacement pattern expanded into an output buffer, clarifies that count returns the number of characters copied to that buffer, and states explicitly that TRUE means the expanded text fit in full. No other comment changes from the artifact were applied. I copied the reviewed draft file from artifacts/src-common-regexp-h-review-20260401, confirmed the worktree diff contains only this one comment block change in src/common/regexp.h, and then ran node --experimental-strip-types src/comment-guard.ts --target-root /mnt/d/source/OpenSal/salamander_codex_pr --artifacts-dir /mnt/d/source/ostranslation/artifacts/src-common-regexp-h-review-20260401 --selected-files src/common/regexp.h with exit code 0 before committing.
janrysavy
commented
Apr 1, 2026
| // 'pattern' is the replacement pattern for the found match, 'buffer' is the output buffer | ||
| // 'bufSize' is the maximum text length including the terminating NULL | ||
| // character, and 'count' returns the number of characters copied to the buffer | ||
| // returns TRUE if the expanded text fit entirely into the buffer |
Owner
Author
There was a problem hiding this comment.
// nahradi promnene \1 ... \9 textem zachycenym odpovidajicima zavorkama
// pattern je vzor kterym se nahrazuje nalezeny match, buffer buffer
// pro vystup, bufSize maximalni velikost textu vcetne ukoncovaciho NULL
// znaku, v promnene count vraci pocet znaku zkopirovanych do bufferu
// vraci TRUE pokud se vyraz vesel cely do bufferuRationale: The candidate is awkward and uses imprecise terms like template and expression; this API describes replacement-pattern expansion into an output buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/common/regexp.hReview
/mnt/d/source/ostranslation/artifacts/src-common-regexp-h-review-20260401/triple-diff-report.html