Review src/common/regexp.cpp#216
Merged
janrysavy merged 1 commit intocomments-translation-v2from Apr 2, 2026
Merged
Conversation
Applied the approved branch-target review result for src/common/regexp.cpp. The landed patch contains seven focused wording fixes in comments only. The changes tighten technical English without changing behavior: the case-insensitive branch label is now explicit, the undefined escape-sequence note drops first-person narration, the escaped-character comment now refers to a parenthesis instead of the broader bracket term, and two old Henry Spencer regex engine block comments were smoothed into more natural English by fixing the article and simplifying the explanatory sentence structure. No unrelated edits were introduced. I copied the reviewed draft file from artifacts/src-common-regexp-cpp-review-20260401, confirmed the worktree diff only contains the expected comment rewrites in src/common/regexp.cpp, and then ran node --experimental-strip-types src/comment-guard.ts --target-root /mnt/d/source/OpenSal/salamander_codex_pr --artifacts-dir /mnt/d/source/ostranslation/artifacts/src-common-regexp-cpp-review-20260401 --selected-files src/common/regexp.cpp with exit code 0 before committing.
janrysavy
commented
Apr 1, 2026
| Line[LineLength] = 0; | ||
| } | ||
| else // insensitive | ||
| else // case-insensitive |
Owner
Author
There was a problem hiding this comment.
// insensitiveRationale: insensitive alone is not idiomatic here; branch is for case-insensitive handling.
janrysavy
commented
Apr 1, 2026
| sour++; | ||
| if (!*sour) | ||
| break; // I should probably throw an error here; such a sequence is not defined | ||
| break; // An error should probably be thrown here; such a sequence is not defined |
Owner
Author
There was a problem hiding this comment.
// tady bych asi mnel hodit chybu takovato sekvence neni definovanaRationale: Meaning is correct, but first-person narration is not suitable for a technical code comment.
janrysavy
commented
Apr 1, 2026
| if (*ss != 0) | ||
| ss++; | ||
| break; // the character after '\\' cannot be treated as a bracket | ||
| break; // the character after '\\' cannot be treated as a parenthesis |
Owner
Author
There was a problem hiding this comment.
// znak za '\\' nemuze byt brany jako zavorkaRationale: bracket is too broad; code tracks parentheses and square brackets separately, here escaped char must not count as a parenthesis.
janrysavy
commented
Apr 1, 2026
| * | ||
| * Implements the concatenation operator. | ||
| * Implements concatenation. | ||
| */ |
Owner
Author
There was a problem hiding this comment.
/*
- regbranch - one alternative of an | operator
*
* Implements the concatenation operator.
*/Rationale: Article and phrasing are slightly unnatural; concise standard wording is better.
janrysavy
commented
Apr 1, 2026
| * | ||
| * Means relocating the operand. | ||
| * This means relocating the operand. | ||
| */ |
Owner
Author
There was a problem hiding this comment.
/*
- reginsert - insert an operator in front of already-emitted operand
*
* Means relocating the operand.
*/Rationale: Missing article makes the current text ungrammatical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/common/regexp.cppReview
/mnt/d/source/ostranslation/artifacts/src-common-regexp-cpp-review-20260401/triple-diff-report.html