Review src/common/messages.h#215
Merged
janrysavy merged 1 commit intocomments-translation-v2from Apr 2, 2026
Merged
Conversation
Applied the approved branch-target review result for src/common/messages.h. The landed change is intentionally minimal: it corrects the dependency note above DMESSAGE_TE so the comment refers to MESSAGE_E, matching the Czech source and the actual macro family instead of the incorrect MESSAGE_TE wording that had slipped into the current branch text. No other comment changes from the review artifact were carried forward. I checked the generated reviewed patch and confirmed that the only source-file delta is this single macro-name correction. That keeps the delivery aligned with the reviewed HTML surface and avoids unrelated churn in the surrounding API comments. Verification: copied the approved draft file from artifacts/src-common-messages-h-review-20260401, confirmed git diff --stat shows exactly one changed line in src/common/messages.h, then ran node --experimental-strip-types src/comment-guard.ts --target-root /mnt/d/source/OpenSal/salamander_codex_pr --artifacts-dir /mnt/d/source/ostranslation/artifacts/src-common-messages-h-review-20260401 --selected-files src/common/messages.h with exit code 0 before committing.
janrysavy
commented
Apr 1, 2026
| #define DMESSAGE_TQW(str, buttons) MESSAGE_TQW(str, (buttons)) | ||
|
|
||
| /// MESSAGE_TE depends on the existence of the MESSAGES_DEBUG macro | ||
| /// MESSAGE_E depends on the existence of the MESSAGES_DEBUG macro |
Owner
Author
There was a problem hiding this comment.
/// MESSAGE_E zavisla na existenci makra MESSAGES_DEBUGRationale: The candidate changes the macro name from MESSAGE_E to MESSAGE_TE, which conflicts with the source comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/common/messages.hReview
/mnt/d/source/ostranslation/artifacts/src-common-messages-h-review-20260401/triple-diff-report.html