Review src/common/heap.cpp#214
Merged
janrysavy merged 1 commit intocomments-translation-v2from Apr 2, 2026
Merged
Conversation
janrysavy
commented
Apr 1, 2026
|
|
||
| // show a warning message box | ||
| MSG msg; // remove possibly buffered ESC key (not to close msgbox immediately) | ||
| MSG msg; // remove any buffered ESC key so the message box does not close immediately |
Owner
Author
There was a problem hiding this comment.
// remove possibly buffered ESC key (not to close msgbox immediately)Rationale: Expands the shorthand wording into clearer technical English while preserving the original meaning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated review for src/common/heap.cpp.
Approved change surface matches the generated HTML review artifact from src-common-heap-cpp-fix-rerun-r3-20260401.
This PR lands the accepted inline comment wording cleanup only.