Skip to content

Add a way to specify which browser vivify should open.#293

Merged
jannis-baum merged 4 commits into
mainfrom
291-add-a-way-to-specify-which-browser-vivify-should-open
Apr 15, 2026
Merged

Add a way to specify which browser vivify should open.#293
jannis-baum merged 4 commits into
mainfrom
291-add-a-way-to-specify-which-browser-vivify-should-open

Conversation

@jannis-baum

Copy link
Copy Markdown
Owner

Close #291

@jannis-baum jannis-baum requested a review from tuurep April 1, 2026 09:00
Comment thread docs/customization.md
@tuurep

tuurep commented Apr 3, 2026

Copy link
Copy Markdown
Collaborator

yarn test fails on main too (not related to this PR)

@tuurep

tuurep commented Apr 3, 2026

Copy link
Copy Markdown
Collaborator

A lead:

yarn test is this:

node --loader ts-node/esm --test tests/unit/cli.ts tests/unit/alerts.ts

It fails with something like:

node:internal/modules/run_main:107
    triggerUncaughtException(
    ^
[Object: null prototype] {
  Symbol(nodejs.util.inspect.custom): [Function: [nodejs.util.inspect.custom]]
}

But if you run the two test files individually without the --test flag, they work, i.e.:

  • node --loader ts-node/esm tests/unit/alerts.ts
  • node --loader ts-node/esm tests/unit/cli.ts

What would that tell us?

@tuurep tuurep left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyways, looks good apart from the faulty JSON in docs!

@jannis-baum

Copy link
Copy Markdown
Owner Author

@tuurep can you reproduce yarn test failing locally? For me it runs without errors both on this branch as well as on main, outputs the following: test-output.txt

@jannis-baum jannis-baum force-pushed the 291-add-a-way-to-specify-which-browser-vivify-should-open branch from 2a5866c to a694c67 Compare April 13, 2026 13:36
@jannis-baum

Copy link
Copy Markdown
Owner Author

Seems like the issue was caused by a node update and I still had the old version. Should be good now, let's merge #296 first and then this one afterwards (I already rebased on top of that one to check that everything works here as well)

@tuurep tuurep left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it works for me

@jannis-baum jannis-baum merged commit 294a5b8 into main Apr 15, 2026
7 checks passed
@jannis-baum jannis-baum deleted the 291-add-a-way-to-specify-which-browser-vivify-should-open branch April 15, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a way to specify which browser vivify should open.

2 participants