Add a way to specify which browser vivify should open.#293
Merged
jannis-baum merged 4 commits intoApr 15, 2026
Merged
Conversation
tuurep
reviewed
Apr 3, 2026
Collaborator
|
|
Collaborator
|
A lead:
It fails with something like: But if you run the two test files individually without the
What would that tell us? |
tuurep
requested changes
Apr 3, 2026
tuurep
left a comment
Collaborator
There was a problem hiding this comment.
Anyways, looks good apart from the faulty JSON in docs!
Owner
Author
|
@tuurep can you reproduce |
Co-authored-by: Tuure Piitulainen <tuure.piitulainen@gmail.com>
2a5866c to
a694c67
Compare
Owner
Author
|
Seems like the issue was caused by a node update and I still had the old version. Should be good now, let's merge #296 first and then this one afterwards (I already rebased on top of that one to check that everything works here as well) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #291