Create fedora rpms build artifacts for release#7346
Open
SidShetye wants to merge 3 commits intojanhq:mainfrom
Open
Create fedora rpms build artifacts for release#7346SidShetye wants to merge 3 commits intojanhq:mainfrom
SidShetye wants to merge 3 commits intojanhq:mainfrom
Conversation
Contributor
|
Please keep the commit of changing |
…ntion)" This reverts commit e1f659a.
Contributor
|
Hey there, wish I had remembered to search through PRs to find this before submitting an issue and figuring it out on my own, but I got the job done with this little hack: #4543 (comment) Out of curiosity, is this of any use, or would the script have found the libraries for Fedora's repos automatically once you added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This change creates rpm build artifacts for Fedora and related distros.
Why rpm ?
This was briefly raised at #6115 (I was absent there, just found this project a couple of hours back) but that was closed as providing flatpak as an alternative. However flatpak's sandbox and portals actually get in the way when trying to manage various custom llamas and models, while a native rpm is able to work very easily with the existing model and runtime libraries on a system.
Example:
In
~/.var/app/ai.jan.Jan/data/Jan/data/llamacpp/models/some-model.gguf/model.ymlyou might haveThose entries are very opaque, leading to a poor experience. Plus those
/run/user/1000/doc/<id>/entries are ephemeral mount points created by the xdg-document-portal service, so they are on their own lifecycle.All said and done, the native deb or rpm application run is great for power users on Linux.
Other considerations
I kept the commit to have the binary called
janas opposed toJanby default as a separate commit to allow easy picking. I personally think aJanbinary is weird on linux but so you guys can decide :) !