Time range for a monitor

[cpina]

There is time range for alerters (https://simplemonitor.readthedocs.io/en/latest/alerters.html#time-restrictions). but I'd like the same for monitors.

I have some alerters that monitor things that are expected to not work at certain times.

I can think of some work arounds as a user, but I think that it would be handy to be able to set it up in simplemonitor.

[jamesoff]

Interesting use case :) And putting those monitors in a group with an alerter with the right time configuration doesn’t cover the requirement? (I guess it would be things like having them show up as FAIL in the HTML status page is what you’re trying to avoid.)

What should a monitor do when it’s not in its time range? It could return SKIP which is what it does if you have a monitor with a gap configured, although that generally leaves it in the state is was in before so it could end up still in the FAIL state if that’s what it was in when the don’t-monitor time period starts. The status page doesn’t show the SKIP status because it’s more an internal flag currently.

[cpina]

I think that putting those monitors in a group and alerter with that time range works. But then I need to duplicate the alerter (with its username, password, etc. it's an email alerter) to have two I think: the 24h alerter and the alerter with the time_lower and time_upper.

I would expect that goes to SKIP status.

My use-cases for this, if it helps modelling this:

• Load average expected to be less than XXX, but not between some hours where usually there is higher load average due to certain batch tasks
• Connectivity expected, but not between time_lower and time_upper when it's not expected because some network equipment restart daily

Thanks for considering it!

[steven-geo]

I too have this requirement, ie for things that should only be turned on during business hours - ignore after hours as they should be off.

TODO:
Add time restrictions config to Monitors (monitor.py) [days, times_type, time_lower, time_upper, times_tz, delay]
Add Time Testing to Monitors (test_monitor.py) [equivalent to test_alterter.py]
Add time restrictions to Monitor common configuration (monitors.rst)

[steven-geo]

I will start working on this shortly. Been doing a few other smaller changes to get used to the code/process as this feels like quite a big change.

[steven-geo]

TODO: Fix Alerters doco param 'day' should be 'days': https://simplemonitor.readthedocs.io/en/latest/alerters.html#confval-day

[steven-geo]

Pull Request 1939 created to implement this: #1939