Skip to content

Conversation

@chrissantamaria
Copy link

👋 big fan of this project! makes the migration to typed-redux-saga much simpler :)

I did notice a minor bug - looks like yield expressions without arguments (i.e. just yield;) cause a crash due to the following section:

YieldExpression(node) {
tracker.enterYieldExpression(node);
if (!node.delegate && isSagaCall(node.argument)) {

With no arguments, node.argument is null which isSagaCall isn't able to handle.

I've added a tiny check to just return false for that case since it's clearly not a saga call, though the defensive logic could be moved to consumers of isSagaCall as well.

@chrissantamaria
Copy link
Author

cc @SantoJambit @Lusito, any chance this could get merged + released? happy to make any necessary changes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant