Skip to content

Conversation

@jakejarvis
Copy link
Owner

@jakejarvis jakejarvis commented Nov 27, 2025

Truncate long domain names in the report header with an ellipsis and add a tooltip to prevent UI overflow.


Open in Cursor Open in Web

Summary by CodeRabbit

  • Bug Fixes

    • Improved domain header layout stability to prevent icons and controls from shrinking and overlapping.
    • Long domain names now truncate with a hover tooltip to reveal the full domain.
  • Style

    • Adjusted spacing and alignment for favicons, external links, and action controls for consistent visual presentation.

✏️ Tip: You can customize this high-level summary in your review settings.

@cursor
Copy link

cursor bot commented Nov 27, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Refines layout classes in the domain report header to prevent overflow: adds spacing and min-width constraints, makes the domain heading truncatable with a title attribute, and marks favicon, external link, export/tools group elements as non-shrinking to preserve layout.

Changes

Cohort / File(s) Summary
Layout and overflow prevention
components/domain/domain-report-header.tsx
Added min-w-0 and gap-4 to outer container; set inner link container to min-w-0 and flex-1; made domain heading truncate and added title={domain}; applied flex-shrink-0 to favicon, ExternalLink, export/tools group and related wrappers; adjusted spacing/alignment classes.

Poem

🐰 I nibble CSS with gentle paws,
Truncate the long domain because,
Icons stand firm, they will not shrink,
Spacing neat—no overflow to blink,
A tidier header—hop, applause!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adjusting the domain name display on the report page to handle overflow with truncation and tooltip.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8eaa03 and 7b496db.

📒 Files selected for processing (1)
  • components/domain/domain-report-header.tsx (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link

vercel bot commented Nov 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
domainstack Ready Ready Preview Comment Nov 28, 2025 4:40pm

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.33%. Comparing base (7a23717) to head (7b496db).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   71.33%   71.33%           
=======================================
  Files         107      107           
  Lines        2976     2976           
  Branches      879      879           
=======================================
  Hits         2123     2123           
  Misses        504      504           
  Partials      349      349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a23717 and e8eaa03.

📒 Files selected for processing (1)
  • components/domain/domain-report-header.tsx (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
components/domain/domain-report-header.tsx (1)
components/domain/favicon.tsx (1)
  • Favicon (11-77)
🪛 GitHub Actions: Run tests and upload coverage
components/domain/domain-report-header.tsx

[error] 28-28: lint/nursery/useSortedClasses: CSS classes should be sorted. Unsafe fix suggested; example shows className with misordered classes.


[error] 34-34: lint/nursery/useSortedClasses: CSS classes should be sorted. Unsafe fix suggested; example shows className with misordered classes.


[error] 39-39: lint/nursery/useSortedClasses: CSS classes should be sorted. Unsafe fix suggested; example shows className with misordered classes.


[error] 41-41: lint/nursery/useSortedClasses: CSS classes should be sorted. Unsafe fix suggested; example shows className with misordered classes.


[error] 47-47: lint/nursery/useSortedClasses: CSS classes should be sorted. Unsafe fix suggested; example shows className with misordered classes.


[error] 53-53: lint/nursery/useSortedClasses: CSS classes should be sorted. Unsafe fix suggested; example shows className with misordered classes.

🔇 Additional comments (2)
components/domain/domain-report-header.tsx (2)

40-45: LGTM! Truncation implementation is correct.

The combination of the truncate class and title attribute properly implements the ellipsis behavior with a hover tooltip to view the full domain name.


28-28: LGTM! Flex layout constraints properly support truncation.

The use of min-w-0 on flex containers enables text truncation to work correctly, while flex-shrink-0 on icons and buttons prevents them from being compressed. The flex-1 on the anchor allows it to take available space while respecting the truncation behavior.

Also applies to: 34-34, 39-39, 47-47, 53-53

@jakejarvis jakejarvis merged commit c9b20e4 into main Nov 28, 2025
2 of 4 checks passed
@jakejarvis jakejarvis deleted the cursor/adjust-domain-name-display-on-report-page-gemini-3-pro-preview-bb98 branch November 28, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants