Open
Conversation
nervo
force-pushed
the
space-locked-as-boolean
branch
from
b500913 to
5b0958d
Compare
jakecoffman
reviewed
Jul 10, 2025
| } | ||
|
|
||
| func (space *Space) Lock() { | ||
| space.locked++ |
Owner
There was a problem hiding this comment.
This would be a behavioral change. With the int someone could be doing:
space.Lock()
space.Lock()
space.Unlock()
space.Unlock()
By changing to a boolean this will now error.
I'm not sure why this would matter but I want to keep close to the original source as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've considered that it could be benefic to use native go boolean instead of emulate it with an integer like in c :)
Also:
assertSpaceUnlockedmethod (same ascpAssertSpaceUnlockedin Chipmunk)Space.IsLocked(same one in Chipmunk)