Repository navigation
Run the Krook reference test only in optimised builds - #267
Merged
Merged
Conversation
The unoptimised Debug build of test_krook_reference takes over 60 s on the CI build hosts (28 s on sCluster before), so its wall-clock limit failed the Debug merge-queue job. The Fast and Release builds check the same reference value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_krook_referenceintegrates about 3,500 near-separatrix orbits with all 641 perturbation modes and stops the binary after 60 s. The unoptimised Debug build needed 28 s on sCluster and needs over 60 s on the CI build hosts that replaced it, even with four dedicated CPUs, so the Debug merge-queue job failed (#266). The optimised builds take about 20 s there and check the same reference value to 1e-6, so the test is now registered only outside the Debug configuration.Checked by configuring both build types:
ctest -Nlists the test in Fast (154 tests) and not in Debug (153 tests).Chris&AI