targets: select wifi-schedule/email-notifications on vnet-wifi profile - #150
Merged
Merged
Conversation
Neither plugin-gargoyle-wifi-schedule nor plugin-gargoyle-email- notifications was selected on any x86 profile, including vnet-wifi -- confirmed by grep and by checking a live vnet VM (neither package nor page file present). This left PR #125's busybox-awk quote-escaping fix on wifi_schedule.sh/email.sh with no path to real simulator coverage. Both are pure shell+JS (PKGARCH:=all, no compiled code), selecting them costs nothing beyond the small package size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugin-gargoyle-wifi-schedulenorplugin-gargoyle-email-notificationswas selected on any x86 build profile, includingvnet-wifi— confirmed by grepping every profile config and by checking a live vnet VM (neither package nor page file was present).wifi_schedule.sh/email.shwith no path to real vnet simulator coverage.PKGARCH:=all, no compiled code or kernel module beyond email's+msmtpdependency), so selecting them costs a small amount of package size, nothing more.Test plan
make x86.vnet-wifirebuild with this config change, to confirm both packages actually build and install cleanly through the normal pipeline (not yet done — the vnet phase this unblocks, see gargoyle-tools phase 61, currently runs against files deployed directly onto the VM rather than a rebuilt image)