Fix system zstd propagation to SPZ - #7537
Open
eclipse0922 wants to merge 1 commit into
Open
Conversation
eclipse0922
marked this pull request as ready for review
August 19, 2026 06:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
When
USE_SYSTEM_ZSTD=ON, Open3D resolves zstd during the top-level CMake configure, but the nested SPZExternalProjectstarts a separate configure without the resolved package location.SPZ then fails to find the system zstd package, downloads its own copy, and disables installation of the SPZ target because the fetched dependency is not exportable. Open3D subsequently cannot compile against the expected installed SPZ headers, such as
spz/load-spz.h.This change passes the top-level
zstd_DIRdirectly to the nested SPZ configure. The bundled-zstd path remains unchanged.Checklist:
python util/check_style.py --applyto apply Open3D code style to my code.CHANGELOG.mddocuments the build fix.Description
The generated
ext_spzconfigure command now contains:Validation performed on Linux with GCC 11.5 and CMake 3.28:
-Dzstd_DIRargument before the change.ext_spzagainst vcpkg zstd and zlib.include/spz/load-spz.handlib/libspz.aare installed.ZSTD_CONFIG_DIR.python util/check_style.py --applywith the pinned style dependencies; all files passed.