add backface culling to Open3DScene and expose the interface to Python - #7527
Open
daizhirui wants to merge 2 commits into
Open
add backface culling to Open3DScene and expose the interface to Python#7527daizhirui wants to merge 2 commits into
daizhirui wants to merge 2 commits into
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open3d.visualization.Visualizercan enable backface culling via theRenderOption. This feature is missing for Open3DScene. This pull request is to add the backface culling feature to Open3DScene and provide the corresponding Python binding. Then, with Python, we can writeType
Motivation and Context
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
backface_cullingtoopen3d::visualization::rendering::MaterialRecord.SetGeometryBackfaceCullingtoopen3d::visualization::rendering::Scene,open3d::visualization::rendering::Open3DSceneandopen3d::visualization::rendering::FilamentScenebackface_cullingtomatforMaterialRecordandset_geometry_backface_cullingtoo3dsceneforOpen3DScene.With

backface_culling=True:With

backface_culling=False: