Fix InSAR Product Spec Issue #304 - #361
Open
xhuang-jpl wants to merge 33 commits into
Open
Conversation
added 30 commits
September 19, 2023 20:40
added 2 commits
August 19, 2026 22:45
…o fix_prod_spec_345
hfattahi
approved these changes
Sep 8, 2026
Comment on lines
52
to
55
| if raster.datatype() == gdal.GDT_Float64: | ||
| stats_obj = isce3.math.compute_raster_stats_float64(raster)[0] | ||
| else: | ||
| stats_obj = isce3.math.compute_raster_stats_float32(raster)[0] |
Contributor
There was a problem hiding this comment.
@bhawkins brought up that this function may not cover 32 bits integer datasets. Let's make sure we are safe
Suggested change
| stats_obj = isce3.math.compute_raster_stats_float32(raster)[0] | |
| if raster.datatype() == gdal.GDT_Float32: | |
| stats_obj = isce3.math.compute_raster_stats_float32(raster)[0] | |
| else: | |
| stats_obj = isce3.math.compute_raster_stats_float64(raster)[0] |
We still may need to raise an exception for int 64 bits.
hfattahi
self-requested a review
September 8, 2026 18:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the InSAR product spec issue #304