Fix the troposphere phase screen datacube across the dateline#330
Conversation
bhawkins
left a comment
There was a problem hiding this comment.
Thanks for the patch. The approach makes sense, though it has some limitations.
| ------- | ||
| the (merged) xarray.Dataset tropospheric delay cube | ||
| ''' | ||
| rtd = tropo_delay_fn or raider_tropo_delay |
There was a problem hiding this comment.
I'm not sure why tropo_delay_fn is introduced. Previously, it seems that you used the radar_tropo_delay at default, and I don't see the usage of tropo_delay_fn.
There was a problem hiding this comment.
it is a parameter of the compute_tropo_delay function and its default is radar_tropo_delay, I can delete it.
bhawkins
left a comment
There was a problem hiding this comment.
LGTM, thanks. Hopefully we can address the remaining gap in a future PR.
hfattahi
left a comment
There was a problem hiding this comment.
We reviewed in a PR review and these changes look good to me.
Please open an issue for the remaining artifact at the dateline boundary.
* fix the tropo across the dateline * address the comments
Problem: The AOI bounding box used plain
min/maxover radar-grid longitudes. For scenes crossing ±180°, wrapped longitudes (e.g.+179°/−179°) inflate the AOI to ~358° wide, so RAiDER loads a near-global weather model and the delay cube is wrong for dateline-crossing acquisitions.Fix: Wrap
raider_tropo_delayincompute_tropo_delay_dateline, which detects the crossing and only then splits the output grid into east/west sub-AOIs, runs each against its own weather-model crop, and merges the cubes back alongx(reassembled in original column order). Non-crossing scenes take a single call with unchanged behavior.Runtime: It takes about 64 seconds on the c5.4xlarge instance, and the plot looks like