Open
Conversation
so that we no longer need Whitebox to test it as a private member of the manager
EasyMock cannot mock final methods.
via GroupManagerTest.
This functionality can be achieved with the equivalent EasyMock methods
to use Mockito, and not use PowerMock
Replay the necessary mocks so that the correct exceptions are thrown.
(JUnit 4 -> JUnit 5)
The Rule annotation is incompatible with JUnit 5, and ExpectedException.none is deprecated anyway.
In JUnit 5 the expected argument order is reversed, so that the message comes last.
The same functionality can now be achieved with just JUnit 5.
Primarily to use JUnit 5. Also correct some spelling, stricten some access modifiers, close a test appender, remove some 'var's, and fix some checkstyle issues.
The additional objects (correctAnswer, wrongAnswer...) need to be initialised before the mock expectations that rely on them are set.
and replace some 'var's
and fix some style issues
and fix some style issues
This serves absolutely no purpose but it's hardcoded into the test cases so I'm changing the test method to match for now.
For consistency with other tests in suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsaacLLMFreeTextValidatorTest. Does not (yet) migrate any other tests to Mockito.In many cases we can remove PowerMock from the test code without modifying the actual implementations being tested, but ec77d14 and b24628f both expose methods that were previously private; we probably need a better solution here.
Maven now finds 567 unit tests to run where it previously found 506.