Skip to content

update#212

Merged
xAdb2 merged 1 commit into
is1ab:mainfrom
mimimaomao1117:feature/my-update
Apr 2, 2026
Merged

update#212
xAdb2 merged 1 commit into
is1ab:mainfrom
mimimaomao1117:feature/my-update

Conversation

@mimimaomao1117
Copy link
Copy Markdown
Contributor

update

Copilot AI review requested due to automatic review settings March 29, 2026 16:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the 2026 member profile page for Mimimaomao and refreshes the npm lockfile to newer dependency patch versions.

Changes:

  • Expanded Mimimaomao’s bio and added an avatar image to the member page.
  • Added additional competition experiences and participation entries.
  • Updated package-lock.json (patch-level bumps and metadata adjustments).

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/member/2026/Mimimaomao.tsx Adds avatar import/usage, expands bio, and appends new experiences/participations.
package-lock.json Updates locked dependency versions/metadata (e.g., brace-expansion, picomatch).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +69 to 72
title: "國立宜蘭高商-網路安全/資訊與網路技術-職類 指導老師",
datetime: "2024.08 ~ now"
},
{
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace after the closing brace/comma here is unnecessary and can create noisy diffs. Please trim line-ending spaces.

Copilot uses AI. Check for mistakes.
Comment on lines 5 to 7
export const MimimaomaoMemberPage = () => {
const bio = "Mimimaomao"
const bio = "我是 Mimimaomao 主要專注於資訊安全與雲端領域,平時會參與 CTF 與競賽,熟悉 Forensics、藍隊等技術方向,同時也具備 AWS 雲端實務經驗,如 : Lambda、CloudFront、IAM 與資料加密等。未來希望深入研究雲端安全與攻防技術。"
const certificates: MemberCertificateType[] = [
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation inside MimimaomaoMemberPage is inconsistent with other member pages (most use 4-space indentation), which makes the file harder to read/maintain. Please run the repo formatter (or re-indent this block) to match the surrounding project style.

Copilot uses AI. Check for mistakes.
Comment on lines +55 to +60
},
{
title: "全國技能競賽分區賽-雲端運算",
result: "排名: 6(佳作)",
datetime: "2026"
},
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is trailing whitespace after the closing braces/commas in this array, which tends to cause noisy diffs and can violate editor/CI whitespace rules. Please remove the extra spaces at line ends.

Copilot uses AI. Check for mistakes.
Comment on lines 101 to 103
enName="YAO-HUNG, LAI"
avatar={mimimaomao}
institutes={["國立臺北科技大學 資訊安全碩士學位學程 碩零"]}
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace after avatar={mimimaomao} will create unnecessary diff churn and may violate whitespace checks. Please trim the line ending spaces.

Copilot uses AI. Check for mistakes.
@xAdb2 xAdb2 merged commit 4b40875 into is1ab:main Apr 2, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants