[#698] move definition of IRODS_VERSION #784
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanking
reviewed
Nov 25, 2025
Contributor
alanking
left a comment
alanking
left a comment
There was a problem hiding this comment.
Sorry, had a thought while I was staring at this... The way it is now is actually fine since the value is not changing. I just wanted to raise a point for consideration.
Member
|
should we add these words (or similar) in comment form somewhere? for the next reader? |
alanking
dismissed
their stale review
should we add these words (or similar) in comment form somewhere? for the next reader?
Hmm... fair enough. Yes, let's put a comment above the new/moved declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.