Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the new Trade card, allowing a player to steal a random card from an opponent and then give them a card back.
Changes:
- Defines Trade card metadata and user-facing messages.
- Registers Trade in playable card actions.
- Implements Trade interaction flow, including target selection, Nope confirmation, card selection, and result viewing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
resources/messages.json |
Adds Trade-related prompts, success text, and view-button labels. |
resources/cards.json |
Adds the Trade card definition and play constraints. |
eggsplode/cards/steal.py |
Implements the Trade card flow using existing steal/selection UI patterns. |
eggsplode/cards/__init__.py |
Registers Trade as a playable action. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #134