chore: rename type_ fields
#318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub sending_module: Option<MoveModuleQuery>, | ||
| pub sender: Option<GQLAddress>, | ||
| // TODO thibault | ||
| pub type_: MoveType, |
There was a problem hiding this comment.
Did this one not need a #[cynic(rename = "type")]?
| serde(with = "::serde_with::As::<serialization::BinaryMoveStructType>") | ||
| )] | ||
| pub type_: StructTag, | ||
| pub type_tag: StructTag, |
There was a problem hiding this comment.
Should this be named struct_tag?
| pub struct ObjectFilter { | ||
| #[cynic(rename = "type")] | ||
| pub type_: Option<String>, | ||
| pub type_tag: Option<String>, |
There was a problem hiding this comment.
This is actually called "type_filter" in the monorepo because the field is a TypeFilter enum. Wdyt?
There was a problem hiding this comment.
That would be preferable
| pub name: String, | ||
| #[cynic(rename = "type")] | ||
| pub type_: Option<OpenMoveType>, | ||
| pub type_tag: Option<OpenMoveType>, |
There was a problem hiding this comment.
Suggested change
| pub type_tag: Option<OpenMoveType>, | |
| pub open_move_type: Option<OpenMoveType>, |
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.