Fix live HLS downloader not stopping on first Ctrl+C#59
Draft
Fix live HLS downloader not stopping on first Ctrl+C#59
Conversation
Agent-Logs-Url: https://github.com/iori-rs/iori/sessions/d89549a3-4b05-49a8-8d06-09635b14fe41 Co-authored-by: Yesterday17 <8667822+Yesterday17@users.noreply.github.com>
Agent-Logs-Url: https://github.com/iori-rs/iori/sessions/d89549a3-4b05-49a8-8d06-09635b14fe41 Co-authored-by: Yesterday17 <8667822+Yesterday17@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Ctrl + C not stopping HLS stream download
Fix live HLS downloader not stopping on first Ctrl+C
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When downloading live HLS streams, the first Ctrl+C logged a stop message but did not actually stop the downloader if it was blocked waiting for the next segment batch. Users had to press Ctrl+C again to force exit.
Downloader stop behavior
ParallelDownloader::downloadto race stream polling against the stop signal.tokio::select!, so stop is honored even while waiting onstream.next().Regression coverage for live-wait scenario
Test clarity cleanup