feat(tokens): add gray colors #30799
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| // TODO: ADD TYPE | ||
| export const darkPrimitiveColors = { | ||
| // TODO: Update hex values to use the text color variable and background color variable | ||
| gray: generateColorSteps('#ffffff', '#000', true), |
There was a problem hiding this comment.
I decided to use white and black for the base because base should be as simple as possible.
There was a problem hiding this comment.
Created this file so these colors can be exported to iOS since iOS uses the same gray colors. I didn't think we needed duplicate code (one for base and one for iOS) when the colors are the same.
There was a problem hiding this comment.
Created this file so these colors can be exported to iOS since iOS uses the same gray colors. I didn't think we needed duplicate code (one for base and one for iOS) when the colors are the same.
| // TODO: ADD TYPE | ||
| export const defaultPrimitiveColors = { | ||
| // TODO: Update hex values to use the text color variable and background color variable | ||
| gray: generateColorSteps('#fff', '#000'), |
There was a problem hiding this comment.
I decided to use white and black for the base because base should be as simple as possible.
| }, | ||
| components: { | ||
| IonBreadcrumb: { | ||
| separatorColor: '#73849a', |
There was a problem hiding this comment.
All 3 themes use this color so the variable is being set at base.
| background: '#000000', | ||
| }, | ||
| IonBreadcrumb: { | ||
| separatorColor: colors.gray['550']!, |
There was a problem hiding this comment.
All themes use a variable to set separator color. I decided to use the color that iOS uses since it uses the simple gray token steps (black and white). But md and ionic would need to override the colors since they use something else.
| separatorColor: colors.gray['550']!, | ||
| }, | ||
| IonDatetimeButton: { | ||
| bg: colors.gray['300']!, |
There was a problem hiding this comment.
All themes use a variable to set separator color. I decided to use the color that iOS uses since it uses the simple gray token steps (black and white). But md and ionic would need to override the colors since they use something else.
| font-size: 12px; | ||
| font-weight: normal; | ||
|
|
||
| color: var(--ion-color-step-600); |
There was a problem hiding this comment.
This wasn't being used anywhere.
Issue number: resolves #
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information