Skip to content

Remove the last uncached resolve, for real #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddjonker merged 1 commit into from
Oct 9, 2026
Merged

Remove the last uncached resolve, for real #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions runtime/src/main/java/dev/ionfusion/fusion/SyntaxSexp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,12 +374,7 @@ Binding firstTargetBinding(Evaluator eval)
throws FusionException
{
SyntaxSymbol first = firstIdentifier(eval);
if (first != null)
{
Binding binding = first.uncachedResolveMaybe();
if (binding != null) return binding.target();
}
return null;
return (first == null) ? null : first.resolve().target();
}

/**
Expand Down
15 changes: 0 additions & 15 deletions runtime/src/main/java/dev/ionfusion/fusion/SyntaxSymbol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,21 +141,6 @@ Binding resolve()
}


/**
* Resolves this identifier, but doesn't cache the result if it has not
* been previously resolved.
*
* @return null is equivalent to a {@link FreeBinding}, and either may be
* returned.
*/
Binding uncachedResolveMaybe()
{
if (myBoundId != null) return myBoundId.getBinding();

return myWraps.resolveMaybe(getName());
}


/**
* Copies this identifier, caching a top-resolved binding.
* @return not null.
Expand Down
Loading