-
Notifications
You must be signed in to change notification settings - Fork 12
chore: migrate project configuration to pyproject.toml (PEP 621) #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BALJAPALLIANSHUL
wants to merge
8
commits into
iobis:main
Choose a base branch
from
BALJAPALLIANSHUL:chore/migrate-to-pyproject
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1af0d0b
chore: migrate project configuration to pyproject.toml
BALJAPALLIANSHUL f1bc630
fix: update CI workflows to use pyproject.toml
BALJAPALLIANSHUL 71b8611
fix(CI): update workflows and apply code formatting
BALJAPALLIANSHUL bdc259c
style: add final newline to pyproject.toml
BALJAPALLIANSHUL b7453af
feat: bump minimum python version to 3.10
BALJAPALLIANSHUL 84761fa
feat: bump python to >=3.10, test on 3.10-3.14
BALJAPALLIANSHUL 4c1186b
Merge branch 'main' into chore/migrate-to-pyproject
BALJAPALLIANSHUL 07d4fd5
ci: fix workflow indentation
BALJAPALLIANSHUL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,9 +39,8 @@ System prerequisites: python3 | |
| git clone [email protected]:iobis/pyobis.git | ||
| cd pyobis | ||
| # install | ||
| python -m pip install -r requirements.txt | ||
| python -m pip install -r requirements-dev.txt | ||
| python -m pip install -e . | ||
| python -m pip install -r requirements-dev.txt | ||
| # test your installation | ||
| python -m pytest | ||
| # test and generate a coverage report | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,42 @@ | ||
| [build-system] | ||
| requires = ["setuptools>=41.2", "setuptools_scm", "wheel"] | ||
| build-backend = "setuptools.build_meta" | ||
|
|
||
| [project] | ||
| name = "pyobis" | ||
| dynamic = ["version"] | ||
| description = "Python client for OBIS" | ||
| readme = "README.md" | ||
| requires-python = ">=3.10" | ||
| license = {text = "MIT"} | ||
| authors = [ | ||
| {name = "pyOBIS Community", email = "[email protected]"} | ||
| ] | ||
| classifiers = [ | ||
| "Development Status :: 5 - Production/Stable", | ||
| "Intended Audience :: Science/Research", | ||
| "License :: OSI Approved :: MIT License", | ||
| "Operating System :: OS Independent", | ||
| "Natural Language :: English", | ||
| "Programming Language :: Python :: 3", | ||
| "Topic :: Scientific/Engineering :: Bio-Informatics", | ||
| ] | ||
| dependencies = [ | ||
| "pandas", | ||
| "requests>=2.7", | ||
| "requests-cache>=1.2.0,<2.0.0", | ||
| "urllib3<2.0.0", | ||
| ] | ||
|
|
||
| [project.urls] | ||
| Documentation = "https://iobis.github.io/pyobis" | ||
| "Bug Tracker" = "https://github.com/iobis/pyobis" | ||
| "Source Code" = "https://github.com/iobis/pyobis" | ||
|
|
||
| [tool.setuptools] | ||
| packages = ["pyobis"] | ||
|
|
||
| [tool.setuptools_scm] | ||
| write_to = "pyobis/_version.py" | ||
| write_to_template = '__version__ = "{version}"' | ||
| tag_regex = "^(?P<prefix>v)?(?P<version>[^\\+]+)(?P<suffix>.*)?$" |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why are we removing --no-deps here. deps were installed in
Setup Micromambaalready right? this could increase CI time with force reinstallThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I migrated dependencies in requirements.txt into pyproject.toml. But I did not migrate dev dependencies to it because of
nbsphinxlibrary. The library depends onpandoctool which is non python. Such tools (depends on conda binaries) are automatically installed with micromamba, but pip cannot do it. And also micromamba cannot read the pyproject.toml. so I left dev dependencies separate and installed inSetup Micromamba. I removed the --no-deps because because it needs to install dependencies in pyproject.toml and prevent environment mismatch as well. I thought it won't significantly effect CI time as it will just skip already satisfied requirements.I have 2 suggestions to this blunder let me know which one is better.