Mark empty signature fields on the page preview - #484
Merged
Conversation
- The shading of form fields came from the JPedal preview backend; 3.2.0 made PDFBox the default, so empty signature fields stopped being visible. - Draw the markers in SignatureOverlay instead, from the field rectangles, so they show with every backend. - Skip zero-size and hidden widgets, and the selected field (it keeps its own marker). - PdfExtraInfo.getFieldRelativeRects() reads all field rectangles with one document open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SignatureOverlayfrom the field rectangles, so they show with every backend, and they are read once per document (PdfExtraInfo.getFieldRelativeRects()).SignatureOverlayTest(geometry, replacement, clearing, z-order) and a batch-read case inSignatureFieldResolutionTest; fulljsignpdfmodule suite passes.