Skip to content

Conversation

mkurapov
Copy link
Contributor

@mkurapov mkurapov commented Oct 17, 2025

Changes proposed in this pull request

  • Handle null subjectId gracefully in the MASE, and avoid this error when consenting to a grant without the subject field:
Screenshot 2025-10-17 at 17 56 28

Context

Related to RAF-997 | #3344

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

cozminu and others added 30 commits May 27, 2025 16:54
Co-authored-by: Max Kurapov <[email protected]>
@mkurapov mkurapov marked this pull request as ready for review October 17, 2025 17:06
@mkurapov mkurapov requested a review from njlie October 17, 2025 17:06
Copy link

github-actions bot commented Oct 17, 2025

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 37.21
  • Iterations/s: 12.43
  • Failed Requests: 0.00% (0 of 2242)
📜 Logs

> [email protected] run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 810 kB 13 kB/s
     data_sent......................: 1.7 MB 29 kB/s
     http_req_blocked...............: avg=7.29µs   min=2.27µs   med=5.96µs   max=515.03µs p(90)=7.16µs   p(95)=7.82µs  
     http_req_connecting............: avg=426ns    min=0s       med=0s       max=453.21µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=106.82ms min=8.04ms   med=87.37ms  max=569.66ms p(90)=183.7ms  p(95)=206ms   
       { expected_response:true }...: avg=106.82ms min=8.04ms   med=87.37ms  max=569.66ms p(90)=183.7ms  p(95)=206ms   
     http_req_failed................: 0.00%  ✓ 0         ✗ 2242
     http_req_receiving.............: avg=104.15µs min=28.39µs  med=89.2µs   max=2.97ms   p(90)=136.06µs p(95)=174.94µs
     http_req_sending...............: avg=41.21µs  min=11.7µs   med=30.97µs  max=4.78ms   p(90)=43.71µs  p(95)=57.96µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=106.68ms min=7.84ms   med=87.13ms  max=569.5ms  p(90)=183.59ms p(95)=205.86ms
     http_reqs......................: 2242   37.213837/s
     iteration_duration.............: avg=321.46ms min=205.64ms med=307.15ms max=1.13s    p(90)=386.61ms p(95)=424.39ms
     iterations.....................: 749    12.432277/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

njlie
njlie previously approved these changes Oct 17, 2025
@njlie
Copy link
Contributor

njlie commented Oct 17, 2025

Good catch!

Base automatically changed from cozmin/raf-996 to main October 20, 2025 10:48
@cozminu cozminu dismissed njlie’s stale review October 20, 2025 10:48

The base branch was changed.

# Conflicts:
#	localenv/mock-account-servicing-entity/app/routes/mock-idp._index.tsx
Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 2aca95f
🔍 Latest deploy log https://app.netlify.com/projects/brilliant-pasca-3e80ec/deploys/68f617f2be892c0008c36d80

Copy link
Contributor

@cozminu cozminu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkurapov mkurapov merged commit db600ca into main Oct 20, 2025
44 checks passed
@mkurapov mkurapov deleted the max/raf-997 branch October 20, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants