fix content type split/parsing, using racks implementation - #455
Conversation
ydah
left a comment
ydah
left a comment
There was a problem hiding this comment.
Seems good! I thought it would be better to have test code for this change, but is it difficult to write test code for this change? (This is not a blocker of merges)
|
@ydah Good point. I had at least in part done this so the person reporting the issue could check and see if it fixed their problem (which it did), but tests would be good before proceeding for sure. |
|
Awaiting confirmation from #454 that it works as expected in Rails and doesn't break anything. Would be good to have testing here also (should be easier around schema validator, somewhat harder on the operation wrapper since it's a bit buried in internals). Might need to rework things a bit to better facilitate testing, but I'll wait for confirmation, lest I waste time on testing the wrong things. |
- Add test cases for Committee::SchemaValidator#request_media_type - Verify parsing of simple, comma-separated, and semicolon-separated content types - Ensure correct media type extraction from request headers
|
#454 was confirmed and I've added some basic tests around the schema_validator at least (where it's more accessible). |
|
Released in v5.6.1 |
|
Thank you @geemus 🙌 |
|
Thank you! |
3 participants
fixes #454