ov_stateful_patch_utils: Remove NPUW WA for avoiding SinCos when context_len >= 2048 #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes a workaround in the NPUW (NPU Workload) stateful flow that was offloading SinCos operations to CPU when the context length exceeded 2048 tokens. The workaround is no longer necessary due to accuracy fixes in the NPU plugin and drivers.
Key Changes:
- Removed conditional logic that configured CPU fallback for SinCos operations in contexts >= 2048 tokens
- Simplified the
UpdateNPUConfigfunction by eliminating the threshold check and associated configuration overrides
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Changes look harmless in terms of functionality but need compatibility assessment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For stateful NPUW flow, remove the WA where SinCos is offloaded to CPU when MAX_PROMPT_LEN + MIN_RESPONSE_LEN >= 2048
Motivation and Context
This is no longer needed, as there have been accuracy fixes in NPU plugin / NPU drivers.
ref. CVS-173936