Skip to content

Conversation

@mengniwang95
Copy link
Contributor

@mengniwang95 mengniwang95 commented Oct 24, 2025

User description

Type of Change

bug fix

Description

detail description

Expected Behavior & Potential Risk

the expected behavior that triggered by this PR

How has this PR been tested?

how to reproduce the test (including hardware information)

Dependency Change?

any library dependency introduced or removed


PR Type

Bug fix


Description

  • Corrected GPU setting in benchmark script

Diagram Walkthrough

flowchart LR
  A["Incorrect GPU setting"] -- "Fixed" --> B["Correct GPU setting"]
Loading

File Walkthrough

Relevant files
Bug fix
run_benchmark.sh
Fix GPU setting in benchmark script                                           

examples/pytorch/diffusion_model/diffusers/flux/run_benchmark.sh

  • Updated GPU setting to use specific IDs from CUDA_VISIBLE_DEVICES
+1/-1     

@XuehaoSun XuehaoSun added this to the 3.6 milestone Oct 24, 2025
@PRAgent4INC
Copy link
Collaborator

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Issue

The change assumes that gpu_ids array indices directly correspond to the physical GPU IDs, which may not always be the case. This could lead to incorrect GPU assignments if CUDA_VISIBLE_DEVICES is set to a non-sequential list of GPU IDs.

export CUDA_VISIBLE_DEVICES=${gpu_ids[i]}

@PRAgent4INC
Copy link
Collaborator

PR Code Suggestions ✨

No code suggestions found for the PR.

@XuehaoSun XuehaoSun merged commit 35f8cfb into master Oct 24, 2025
12 checks passed
@XuehaoSun XuehaoSun deleted the mengniwang95-patch-2 branch October 24, 2025 02:04
XuehaoSun pushed a commit that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants