.github/workflows: Migrate workflows to Blacksmith runners - #18
.github/workflows: Migrate workflows to Blacksmith runners#18blacksmith-sh[bot] wants to merge 3 commits into
Conversation
|
Droid finished @blacksmith-sh[bot]'s task —— View job Validated 2 candidate comments and approved both. Main risks are template downstream clones inheriting |
| jobs: | ||
| validate: | ||
| runs-on: ubuntu-24.04 | ||
| runs-on: blacksmith-4vcpu-ubuntu-2404 |
There was a problem hiding this comment.
[P1] Document Blacksmith requirement for template clones
Because this repo is a template that gets cloned into downstream instances, switching runs-on to blacksmith-* can leave CI jobs queued (no matching runner) unless each clone installs/configures the Blacksmith GitHub App. Consider documenting that prerequisite clearly (or keeping a GitHub-hosted default runner and making Blacksmith opt-in) to avoid surprising broken CI in new clones.
| droid-review: | ||
| if: github.event.pull_request.draft == false && github.event.pull_request.head.repo.full_name == github.repository | ||
| runs-on: ubuntu-latest | ||
| runs-on: blacksmith-8vcpu-ubuntu-2404 |
There was a problem hiding this comment.
[P1] [security] Confirm blacksmith-* runner scope and repo restrictions
If Blacksmith runners/labels are registered at the org level, any repository in the org could potentially target runs-on: blacksmith-* unless runner groups (or app installation scope) restrict which repos can use them. Please confirm these runners are limited to the intended repos to avoid unintended third-party code exposure and billing/DoS surprises for downstream clones.
There was a problem hiding this comment.
Blacksmith runners are not org-registered self-hosted runners: the blacksmith-* labels are only resolved for repositories covered by the Blacksmith GitHub App installation, whose repo scope and billing are controlled in the installation settings rather than in workflow files. Clones without the app simply queue with no matching runner, a prerequisite now documented in the README per the companion comment.
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
|
Droid finished @blacksmith-sh[bot]'s task —— View job Validated 0 candidate review comments (0 approved, 0 rejected). No new high-confidence issues found in this diff. Prior concerns about Blacksmith prerequisites for template clones and runner scope are already covered in existing PR comments and documentation updates. |
This PR has been automatically generated by a team member in your GitHub organization using Blacksmith's Migration Wizard. This PR changes the following:
runs-on: blacksmith-4vcpu-ubuntu-2204). Learn more about the different instances available to choose from.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.