Skip to content

[CLX-3161][S] Fix bugs #1 #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2025
Merged

[CLX-3161][S] Fix bugs #1 #3732

merged 3 commits into from
Oct 30, 2025

Conversation

@Ahmed-Naguib93
Copy link
Contributor

@Ahmed-Naguib93 Ahmed-Naguib93 commented Oct 29, 2025 •
edited by atlassian bot
Loading

refs: CLX-3161,3162,3163,3164.3165,3166
builds: Student
affects: Student
release note: none

1- CLX-3161
2- CLX-3162
3- CLX-3163
4- CLX-3164
5- CLX-3165
6- CLX-3166

@Ahmed-Naguib93
fix: bugs
357a167 
refs: CLX-3161,3162,3163,3164.3165,3166
builds: Student
affects: Student
release note: none

test plan:
@Ahmed-Naguib93 Ahmed-Naguib93 self-assigned this Oct 29, 2025
@Ahmed-Naguib93 Ahmed-Naguib93 added the career Canvas Career Experience label Oct 29, 2025
@inst-danger
Copy link
Contributor

inst-danger commented Oct 29, 2025 •
edited
Loading

Builds

Commit: fix: typo (c3ba46b)
Build Number: 677
Built At: Oct 30 06:17 CET (10/29 11:17 PM MDT)

Student

@inst-danger
Copy link
Contributor

inst-danger commented Oct 29, 2025 •
edited
Loading

Warnings
⚠️ This pull request will not generate a release note.
⚠️ One or more files are below the minimum test coverage 50%
⚠️ The total test coverage is below the minimum 90%

Affected Apps: Student

Builds: Student

Coverage New % Master % Delta
Canvas iOS 80.84% 80.41% 0.43%
Horizon/Horizon/Sources/Features/Dashboard/SkillsHighlightsWidget/Data/ProficiencyLevel.swift 0% -- --
Horizon/Horizon/Sources/Features/Notebook/Common/View/HighlightWebView/HighlightWebFeature.swift 0% 0% 0%
Horizon/Horizon/Sources/Features/Notebook/Common/View/HighlightWebView/EnableZoom.swift 0% 0% 0%
Horizon/Horizon/Sources/Common/Domain/GetCoursesInteractor.swift 38.16% 38.16% 0%
Horizon/Horizon/Sources/Features/LearningObjects/Assignment/SubmissionComment/Data/CommentAttachment.swift 0% 0% 0%
Horizon/Horizon/Sources/Features/Account/Notifications/Domain/NotificationSettingsInteractor.swift 0% 0% 0%
Horizon/Horizon/Sources/Features/Session/SessionInteractor.swift 33.33% 33.33% 0%
Horizon/Horizon/Sources/Common/Data/HModuleStatus.swift 0% 0% 0%
Horizon/Horizon/Sources/Features/Assist/AssistFlashCard/View/AssistFlashCardViewModel.swift 0% 0% 0%
Horizon/Horizon/Sources/Features/LearningObjects/Assignment/AssignmentDetails/View/AssignmentSubmissionType.swift 0% 0% 0%

Generated by 🚫 dangerJS against c3ba46b

@claude

This comment was marked as resolved.

Sign in to view
@instructure instructure deleted a comment from claude bot Oct 30, 2025
@instructure instructure deleted a comment from claude bot Oct 30, 2025
@Ahmed-Naguib93 Ahmed-Naguib93 merged commit 12c111c into master Oct 30, 2025
5 checks passed
@Ahmed-Naguib93 Ahmed-Naguib93 deleted the feature/horizon-fix-bugs branch October 30, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szabinst szabinst szabinst approved these changes

@ktheory ktheory Awaiting requested review from ktheory ktheory is a code owner

@JacksonHowe JacksonHowe Awaiting requested review from JacksonHowe JacksonHowe is a code owner

@vargaat vargaat Awaiting requested review from vargaat vargaat is a code owner

@rh12 rh12 Awaiting requested review from rh12 rh12 is a code owner

@suhaibabsi-inst suhaibabsi-inst Awaiting requested review from suhaibabsi-inst suhaibabsi-inst is a code owner

Assignees

@Ahmed-Naguib93 Ahmed-Naguib93

Labels

career Canvas Career Experience

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ahmed-Naguib93 @inst-danger @szabinst