[MBL-19374][S] Add mark as done to To-do screen #3722

vargaat · 2025-10-22T07:47:19Z

What's new?

Added mark-as-done functionality to the Todo list, allowing users to mark todo items as complete via checkbox or swipe gesture.
For the swipe gesture I checked our existing solution in the codebase but that doesn't support the full swipe functionality. I checked two 3rd parties, but I wasn't satisfied with them either, so I created a new implementation that only supports the full swipe gesture.
- There were multiple challenges during implementation, most of them came from the fact that our gesture recognizer has no connection with other gesture recognizers on the screen (scroll view's pull to refresh gesture and the cell button's tap gestures). After a lot of trial and errors, the best was to use tap gestures instead of buttons, this solved the issue of the button and the checkbox triggering during swipe (but we've lost the highlight on slow taps). The other thing was to prevent the vertical scrollview scrolling while swiping horizontally, which was achieved by a binding that disables the scrollview's scrolling ability while the horizontal swipe is in progress.

There will be further changes to this screen in the epic, so E2E tests will be written when the screen takes its final form.

refs: MBL-19374
builds: Student
affects: Student
release note: Added mark-as-done feature to new To-do screen.
test plan: See ticket.

Screenshots

Happy Flow	Failure
ScreenRecording_10-22-2025.10.MP4	ScreenRecording_10-22-2025.9.MP4

Checklist

refs: MBL-19373 builds: Student affects: Student release note: none test plan: - Compare design with figma. - Check accessibility. - Validate proper grouping by dates.

# Conflicts: # Core/CoreTests/Features/Todos/Model/TodoInteractorLiveTests.swift

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

- Move API logic from view model to TodoInteractor - Inject router dependency into TodoListViewModel - Prevent multiple taps from firing duplicate API requests - Update todo badge counter when marking items done/undone - Add comprehensive unit tests for new behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

refs: MBL-19374 builds: Student affects: Student release note: Added mark-as-done feature to new To-do screen. test plan: See ticket. Co-Authored-By: Claude <[email protected]>

…estures.

inst-danger · 2025-10-22T08:04:15Z

	Warnings
⚠️	One or more files are below the minimum test coverage 50%
⚠️	The total test coverage is below the minimum 90%

Release Note:

Added mark-as-done feature to new To-do screen.

Affected Apps: Student

Builds: Student

MBL-19374

Coverage	New %	Master %	Delta
Canvas iOS	80.38%	80.31%	0.07%
Horizon/Horizon/Sources/Features/Notebook/Common/View/HighlightWebView/HighlightWebFeature.swift	0%	0%	0%
Horizon/Horizon/Sources/Features/Notebook/Common/View/HighlightWebView/EnableZoom.swift	0%	0%	0%
Horizon/Horizon/Sources/Common/Domain/GetCoursesInteractor.swift	38.16%	38.16%	0%
Horizon/Horizon/Sources/Features/LearningObjects/Assignment/SubmissionComment/Data/CommentAttachment.swift	0%	0%	0%
Horizon/Horizon/Sources/Features/Account/Notifications/Domain/NotificationSettingsInteractor.swift	0%	0%	0%
Horizon/Horizon/Sources/Common/Utilities/Double+.swift	0%	0%	0%
Horizon/Horizon/Sources/Common/Data/HModuleStatus.swift	0%	0%	0%
Horizon/Horizon/Sources/Features/Session/SessionInteractor.swift	33.33%	33.33%	0%
Horizon/Horizon/Sources/Features/Assist/AssistFlashCard/View/AssistFlashCardViewModel.swift	0%	0%	0%
Horizon/Horizon/Sources/Features/LearningObjects/Assignment/AssignmentDetails/View/AssignmentSubmissionType.swift	0%	0%	0%

Generated by 🚫 dangerJS against f083389

- Extract cancelDelayedRemove helper to properly cancel and remove timers - Fix UpdatePlannerOverrideRequest to return APIPlannerOverride instead of APINoContent - Remove debug-only .make() usage from production code in MarkPlannableItemDone - Simplify API request handling to use actual responses - Update test mocks to return proper APIPlannerOverride objects - Add MARK comments for better code organization 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

… to remove.

inst-danger · 2025-10-22T10:13:41Z

Builds

Commit: Remove unnecessary HStack and public modifiers. Add preview for swipe to remove. (f083389)
Build Number: 624
Built At: Oct 22 12:13 CEST (10/22 04:13 AM MDT)

Student

suhaibabsi-inst

Code +1

suhaibabsi-inst · 2025-10-28T08:50:52Z

Core/Core/Common/CommonUI/InstUI/Utils/SwipeToRemove.swift

+
+private struct SwipeToRemoveModifier<Label: View>: ViewModifier {
+    let backgroundColor: Color
+    let isSwiping: Binding<Bool>?


Why not using @Binding var isSwiping: Bool ?

suhaibabsi-inst · 2025-10-28T09:00:56Z

Core/Core/Features/Todos/View/TodoListItemCell.swift

    let onTap: (_ item: TodoItemViewModel, _ viewController: WeakViewController) -> Void
+    let onMarkAsDone: (_ item: TodoItemViewModel) -> Void
+    let onSwipeMarkAsDone: (_ item: TodoItemViewModel) -> Void
+    let isSwiping: Binding<Bool>?


Here as well. Why not use @Binding ?

suhaibabsi-inst

Tested on iPhone XS, iOS 18.3.1.

✅ QA +1 for the most of UI features mentioned.

One minor issue:
Checkbox doesn't fade in-out as we swipe cell as mentioned in Figma file.

See record below:

ScreenRecording_10-28-2025.12-59-00_1.MP4

vargaat and others added 30 commits September 26, 2025 15:16

Introduce temporary feature flag.

086a2be

Remove isEmpty state publishing.

92a4f83

Add tab and application badge update logic.

292f4f9

Use +-28 days interval for todo fetching.

5c2ac15

Use local env variable for fetching.

1feaef4

Extract todo cell content view to Core.

7a4813a

Update todo item layout.

dbc7b04

Use shared todo cells for widget and todo screen.

9d217cc

Add sticky day headers.

892aaf9

Update layout.

cbbe33b

Route to calendar when tapping on the day header.

7a17678

Improve a11y.

7ac197a

Move entities to the view model level.

4ee2924

Continue renaming.

3a9c5c1

Move sorting logic to view model entities.

b8d723f

Update unit tests.

74c390b

Update layout.

6bed69e

Display only time

e45f352

refs: MBL-19373 builds: Student affects: Student release note: none test plan: - Compare design with figma. - Check accessibility. - Validate proper grouping by dates.

Update empty state.

474f0c4

Update course name lookup logic.

d63b8c6

Merge branch 'master' into feature/MBL-19373-Update-ToDo-Screen

9cb87cf

Update public previews.

465b4b6

Update dividers for better section scrolling experience.

7e0273c

Merge branch 'master' into feature/MBL-19373-Update-ToDo-Screen

da84fa7

Fix flaky test.

80a6c59

Optimize course lookup.

38b1433

Merge branch 'master' into feature/MBL-19373-Update-ToDo-Screen

07d850d

# Conflicts: # Core/CoreTests/Features/Todos/Model/TodoInteractorLiveTests.swift

Implement code review suggestions. Improve a11y.

92cc847

Add DB fields required for mark as done feature.

6b51e2a

Add MarkPlannableItemDone use case with tests

8354bed

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

vargaat and others added 20 commits October 16, 2025 09:29

Add checkbox and swipe-to-done to TodoListItemCell

6064518

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Add mark-as-done logic to TodoListViewModel

4fe6b5f

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Add filtering for completed items in TodoInteractor

7c4b968

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Add snackbar error handling for mark-as-done

080618d

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Add unit tests for mark-as-done functionality

ac9aa6d

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Add accessibility identifier for checkbox

69bba47

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Fix refresh issues. Update async tests.

d3626ea

Add swipe gesture.

e613c31

Merge branch 'master' into feature/MBL-19374-Add-mark-as-done-to-todo

30ff3c0

Add swipe to done feature.

d35a7b7

Rename id to plannableId.

4080d54

Reset view identity on restoration and force refresh.

1fd77d0

Prevent scrolling while swipe is in action.

cfc5731

Fine tune gesture properties.

3bf743c

Add accessibility support for mark as done feature.

b847f52

refs: MBL-19374 builds: Student affects: Student release note: Added mark-as-done feature to new To-do screen. test plan: See ticket. Co-Authored-By: Claude <[email protected]>

Use tap gesture instead of button to avoid gesture recognizer conflicts.

44d8134

Tweak gesture recognizer to better separate vertical and horizontal g…

87977d9

…estures.

Add analytics events.

bdb9166

Code cleanup.

d823362

vargaat self-assigned this Oct 22, 2025

vargaat requested review from rh12 and suhaibabsi-inst as code owners October 22, 2025 07:47

vargaat and others added 2 commits October 22, 2025 11:12

Remove unnecessary HStack and public modifiers. Add preview for swipe…

f083389

… to remove.

vargaat requested a review from balintbartok October 22, 2025 11:52

suhaibabsi-inst reviewed Oct 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MBL-19374][S] Add mark as done to To-do screen #3722

[MBL-19374][S] Add mark as done to To-do screen #3722

Uh oh!

vargaat commented Oct 22, 2025 •

edited

Loading

Uh oh!

inst-danger commented Oct 22, 2025 •

edited by atlassian bot

Loading

Uh oh!

inst-danger commented Oct 22, 2025

Uh oh!

suhaibabsi-inst left a comment

Uh oh!

suhaibabsi-inst Oct 28, 2025

Uh oh!

suhaibabsi-inst Oct 28, 2025

Uh oh!

suhaibabsi-inst left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[MBL-19374][S] Add mark as done to To-do screen #3722

Are you sure you want to change the base?

[MBL-19374][S] Add mark as done to To-do screen #3722

Uh oh!

Conversation

vargaat commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's new?

Screenshots

Checklist

Uh oh!

inst-danger commented Oct 22, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Note:

Affected Apps: Student

Builds: Student

Uh oh!

inst-danger commented Oct 22, 2025

Builds

Uh oh!

suhaibabsi-inst left a comment

Choose a reason for hiding this comment

Uh oh!

suhaibabsi-inst Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

suhaibabsi-inst Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

suhaibabsi-inst left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vargaat commented Oct 22, 2025 •

edited

Loading

inst-danger commented Oct 22, 2025 •

edited by atlassian bot

Loading