ci: add digest to save_artifact to run image scans - #526
Open
konrad-ohms wants to merge 2 commits into
Open
Conversation
The CI scanning tool runs docker build without passing build args, causing BUILDPLATFORM to be empty and failing with 'invalid component' error. Added default values (linux/amd64) to all ARG declarations to allow builds without explicit --build-arg parameters. The Makefile's container-build target will still override these defaults when building multi-arch images. Signed-off-by: Konrad Ohms <Konrad.Ohms@de.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
I want to run container image scans on every PR.
What
The SPS pipeline can scan images, but apparently requires digests being published, not only image names and tags.
References
n/a
Checklist
Note: Remember to run a helm chart release after the the operator release to make the changes available thru helm.