bugfix date before 1943 #36
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xusifob
force-pushed
the
bugfix/search-birthdate-before-1943
branch
from
d584661 to
bf271de
Compare
Xusifob
force-pushed
the
bugfix/search-birthdate-before-1943
branch
from
bf271de to
44e9ca0
Compare
Member
|
Merged via Cherry-pick on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attention !
Base : bugfix/import-rpps-multiple-address
Si ce n’est pas encore mergé, tu peux cherry-pick le commit, il est très petit.
Contexte
La base "depuis 1943" commence au 1er janvier 1943.
Lorsqu’une date de naissance antérieure à 1943 est utilisée (par exemple 1936), aucune correspondance n’est trouvée car aucune ligne n’existe avant cette date.
Conséquence
La méthode
searchBirthPlacesByDatene retourne alors aucun résultat et renvoie uniquement "INCONNU".Résolution
Un fallback a été ajouté :
InseePays), afin de fournir un résultat pertinent.InseePays1943), qui gère correctement les périodes de validité.