Skip to content

Conversation

kpinter-iohk
Copy link
Contributor

Description

This PR adds a client for the miniBF API implemented by Dolos.
Notes:

  • MiniBFApi trait is there so that hopefully we can switch to a gRPC implementation eventually, which is in the future plans for Dolos.
  • I tried to use our domain types for inputs in the API, however the types returned by the API are from blockfrost-openapi (which is used by Dolos as well), so sometimes a thing id is just a string. This lead to the beautiful McBlockId enum.
  • There is a blockfrost rust crate but unfortunately it doesn't provide the API as a trait, and is for communicating with actual Blockfrost. The Dolos miniBF API also doesn't match Blockfrost 1:1 so I couldn't really use this. I did try to keep names consistent though.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • The size limit of 400 LOC isn't needlessly exceeded
  • The PR refers to a JIRA ticket (if one exists)
  • New tests are added if needed and existing tests are updated.
  • New code is documented and existing documentation is updated.
  • Relevant logging and metrics added
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

@kpinter-iohk kpinter-iohk force-pushed the ETCM-12351-dolos-client branch from 2fc29b0 to ee9d3b9 Compare October 17, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants