Skip to content

Conversation

evgeniy-dikevich
Copy link

Related failed run: https://github.com/input-output-hk/hermes/actions/runs/18532215432/job/52818065856?pr=578 (error is not related to this PR)

This run failed on step https://github.com/input-output-hk/catalyst-forge/blob/master/actions/setup/action.yml#L112

By default 'skip_github' is set to 'true' https://github.com/input-output-hk/catalyst-forge/blob/master/.github/workflows/ci.yml#L82 (it is also true for version which hermes guys use) so this step should not have been performed.

image

This happens cause for JS this statement is correct:

(true && (null != 'null') && ('success' == 'success'))

but why?

Cause first null is object and second one is string 🤦

This PR also should fix situations when we provide bool variable as input and expecte that it will be also bool variable in action but sometimes it is not true 🤣

As a example:

(true != 'true')

Signed-off-by: Evgeniy Dikevich <[email protected]>
Signed-off-by: Evgeniy Dikevich <[email protected]>
Signed-off-by: Evgeniy Dikevich <[email protected]>
Signed-off-by: Evgeniy Dikevich <[email protected]>
Signed-off-by: Evgeniy Dikevich <[email protected]>
Signed-off-by: Evgeniy Dikevich <[email protected]>
Signed-off-by: Evgeniy Dikevich <[email protected]>
Signed-off-by: Evgeniy Dikevich <[email protected]>
Signed-off-by: Evgeniy Dikevich <[email protected]>
Signed-off-by: Evgeniy Dikevich <[email protected]>
Signed-off-by: Evgeniy Dikevich <[email protected]>
Signed-off-by: Evgeniy Dikevich <[email protected]>
Signed-off-by: Evgeniy Dikevich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant