Skip to content

Extract repeated setup steps into reusable composite actions#250

Merged
dottxado merged 29 commits into
mainfrom
fix/247
Jun 26, 2026
Merged

Extract repeated setup steps into reusable composite actions#250
dottxado merged 29 commits into
mainfrom
fix/247

Conversation

@dottxado

@dottxado dottxado commented May 28, 2026

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

What is the current behavior? (You can also link to an open issue here)

Fixes #247
Fixes #183

What is the new behavior (if this is a feature change)?

  • Extract three composite actions
  • Incorporate composer validate on the setup-php composite action so that all the workflows calling it can benefit (before only a part of the workflows were validating composer files)
  • Incorporate the package manager input in the setup-node so that, when we remove Yarn, the logic and the deprecation warning live only in the action
  • Use kebab-case for the actions input, following GitHub convention

Out of scope:

  • deprecated workflows have not been modified

Bonus:

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No, the interface of the workflows has not been changed.

Other information

Log of the tests

  • automatic-release.yml log
  • build-and-distribute.yml log
  • coding-standards-php.yml log
  • deploy-deployer.yml log
  • lint-php.yml log
  • static-analysis-js.yml log ✅ (the workflow didn't end successfully for other reasons)
  • static-analysis-php.yml log
  • test-playwright.yml log
  • tests-unit-js.yml log
  • tests-unit-php.yml log
  • wp-scripts-lint.yml log

@dottxado dottxado marked this pull request as ready for review June 12, 2026 13:49
@dottxado dottxado requested a review from a team June 12, 2026 13:49

@tyrann0us tyrann0us left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for working on this! I really love how this reduces repetition big time. 💪🏽
There's still some room for improvement, IMO; I left several line comments. Also, I feel like AI desperately wants to write a "Notes" section at the end of each documentation file; do we really need those?

Comment thread .github/actions/setup-git/action.yml Outdated
Comment thread .github/actions/setup-git/action.yml Outdated
Comment thread .github/actions/setup-git/README.md Outdated
Comment thread .github/actions/setup-git/README.md Outdated
Comment thread .github/actions/setup-node/action.yml Outdated
Comment thread .github/actions/setup-php/action.yml Outdated
Comment thread .github/actions/setup-php/README.md Outdated
Comment thread .github/actions/setup-php/README.md Outdated
Comment thread .github/actions/setup-php/README.md Outdated
Comment thread .github/workflows/deploy-deployer.yml
tyrann0us and others added 7 commits June 15, 2026 09:17
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Christian Leucht <family.leucht@gmail.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Christian Leucht <family.leucht@gmail.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Christian Leucht <family.leucht@gmail.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Christian Leucht <family.leucht@gmail.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Christian Leucht <family.leucht@gmail.com>
@dottxado dottxado requested a review from a team as a code owner June 23, 2026 07:12
dottxado and others added 7 commits June 23, 2026 09:19
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Erika Gili <e.gili@syde.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Erika Gili <e.gili@syde.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Erika Gili <e.gili@syde.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Erika Gili <e.gili@syde.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Erika Gili <e.gili@syde.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Erika Gili <e.gili@syde.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Erika Gili <e.gili@syde.com>
@dottxado dottxado requested review from Chrico and tyrann0us June 23, 2026 08:06

@tyrann0us tyrann0us left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing all the changes. LGTM 💪🏽

@dottxado dottxado merged commit cbf5f65 into main Jun 26, 2026
3 checks passed
@dottxado dottxado deleted the fix/247 branch June 26, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants